search

zach-r-long / minimega-phenix

minimega
GNU General Public License v3.0
0 stars 1 forks source link

Added Restart, Shutdown, and Reset State buttons to the multiAction bar #8

Closed eric-c-wood closed 3 years ago

eric-c-wood commented 3 years ago

1) Added Restart, Shutdown, and Reset State buttons to the multiAction bar 2) Made several cosmetic UI changes. Added "cancel" buttons to diskImage and redeploy modal dialog boxes. Added "hr" tags when multiple VMs are selected. Added the ability to click on an IP address to start a packet capture.
3) Changed the name of the variable "redeploying" to "busy" as it was being used in places where a VM was not redeploying. "Busy" seems to be more appropriate and makes the code easier to understand. 4) Added in some placeholder buttons to the mutliAction toolbar to get an idea of screen real estate changes.

zach-r-long commented 3 years ago

Looks really good! I like the modify state solution, very elegant!

One Issue.

image

I believe this should be the create backing image and have the old icon. Clicking it brings up the backing image creation UI. image

Otherwise LOOKS GREAT

eric-c-wood commented 3 years ago

I probably swapped some icons around. Also, there are several buttons attached to the wrong handlers as placeholders namely memory snapshot and screen capture/snapshot. I will change the "hdd-o" icon that I used and put the "floppy-o" icon back for the "create backing image" function. I will do that in the next push of UI changes. I will try to keep the commits small and focused around a specific purpose.

Also, the button grouping that I did to conserve screen real estate was just a placeholder for other ideas. It was simple to implement and it was good enough as a temporary solution. I am interested in other ideas and prototyping to see how things look. Also, please change other icons as you see fit. I really do not like the current icons for the "redeploy, reset state, and restart" functions. They are too similar.

On Mon, Dec 7, 2020 at 7:55 AM zach-r-long notifications@github.com wrote:

Looks really good! I like the modify state solution, very elegant! One Issue.

[image: image] https://user-images.githubusercontent.com/6519919/101353051-fe560c00-3860-11eb-897c-4a9372a40f46.png

I believe this should be the create backing image and have the old icon. Clicking it brings up the backing image creation UI. [image: image] https://user-images.githubusercontent.com/6519919/101353221-3c533000-3861-11eb-9c3a-f8ec1d2d7901.png

Otherwise LOOKS GREAT

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zach-r-long/minimega-phenix/pull/8#issuecomment-739900855, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7UOXZSV26QEUITKI6BUQ3STTGD7ANCNFSM4UMSVH5Q .

eric-c-wood commented 3 years ago

Ok, I pushed a new set of updates. Also, I believe that I restored the old icon of "floppy-o" for the create backing image/create disk snapshot function. I added a default handler for the placeholder buttons "create memory snapshot and record screenshot". If the order of the buttons is not to your liking, we can always re-arrange. Currently, the buttons are ordered by function. For example, the buttons associated with snapshots are grouped together.

If you like the concept of button groups to conserve screen real estate, we can always add a button to represent a "snapshot" group. This of course assumes that we might add more buttons in the future.