zach2039 / oldguns

A Minecraft mod that adds a collection of antique firearms. Heavily inspired by Ye Olde Minegunner mod from the beta days of modded Minecraft. Smelt bullets and craft parts to create guns.
GNU Affero General Public License v3.0
4 stars 1 forks source link

Client Gun Crash #29

Closed TheFallenChaos closed 1 year ago

TheFallenChaos commented 2 years ago

Describe the bug A crash that occurs because of the firing of the Medium Naval Canon

To Reproduce Steps to reproduce the behavior:

  1. Place down "Medium Navel Gun"
  2. Load it as you should
  3. Fire it

Expected behavior It should have fired the projectile (configs were untouched), the projectile would then come into contact with packed ice.

Screenshots image

Mod Version oldguns-1.19-3.6.1-33

Mod List image

Additional context We're unsure why this is happening, this says nothing in our server console we are using to test the mod on, only that the crashed player is disconnecting.

zach2039 commented 2 years ago

Do you have a client log or log of any type containing this message? Sometimes mixins/patches from some mods can have a hard-to-trace interaction with other mods; you can sometimes ascertain what mod is causing issues by the list of mixins in the log.

TheFallenChaos commented 2 years ago

Not any I could find, no

SirCatZ commented 1 year ago

copy pasta from another issue entry (but with the same problem):

One of my friends fixed this issue. If i understood it correctly the mod already includes the code to stop distant clients from trying to render the bullets (which crashes the client when this chunks aren't loaded). The error in the code is that the distance is entered wrong (the Minecraft documentation includes a wrong statement, so its not the creators fault (can't remember exactly, but something like if the value is already squared or not)).

i'll include the edited version we used (and tested successfully). Maybe the creator of the mod can later include the fix in an official version.

oldguns-MODIFIED.zip

zach2039 commented 1 year ago

Fixed in both v3.6.3-38 and v3.7.1-39 releases.