search

zach2039 / oldguns

A Minecraft mod that adds a collection of antique firearms. Heavily inspired by Ye Olde Minegunner mod from the beta days of modded Minecraft. Smelt bullets and craft parts to create guns.
GNU Affero General Public License v3.0
4 stars 1 forks source link

Client side crash when firing guns #33

Closed SunjuhCeles closed 1 year ago

SunjuhCeles commented 2 years ago

Client side crash when another player fires a gun 124 blocks away. Player firing the gun is not disconnected. This does not happen when the two players are next to each other

Steps to reproduce the behavior:

  1. Fire any gun with another player on a server
  2. Be at least 100 blocks away
  3. See error

oldgunserror

Version [eg. v1.19-3.6.2-34]

Mod List

modlist

Additional context There is no crash log for the issue

SirCatZ commented 1 year ago

One of my friends fixed this issue. If i understood it correctly the mod already includes the code to stop distant clients from trying to render the bullets (which crashes the client when this chunks aren't loaded). The error in the code is that the distance is entered wrong (the Minecraft documentation includes a wrong statement, so its not the creators fault (can't remember exactly, but something like if the value is already squared or not)).

i'll include the edited version we used (and tested successfully). Maybe the creator of the mod can later include the fix in an official version.

oldguns-MODIFIED.zip

zach2039 commented 1 year ago

duplicate of #29