Add mypy type checking; fix resultant errors.

zach401 / acnportal

Research tools for the Adaptive Charging Network

BSD 3-Clause "New" or "Revised" License

74 stars 31 forks source link

Add mypy type checking; fix resultant errors. #85

Open sunash opened 3 years ago

sunash commented 3 years ago

This PR also includes functionality to allow for altering an EVSE after constraints have been added.

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

chrisyeh96 commented 2 years ago

@sunash @zach401 What's the status on this pull request? It would be great to have more Python typing hints for us to develop our gym against

sunash commented 2 years ago

We would need to get all the type hinting to pass and address the remaining comments. Also if resolving #106 yields a minimum version of python that has future.annotations, the type hints might use that package rather than typing. Either way we should address #106 before moving forward with this PR.