zacharyweston / codelab-css-transitions-animations-transforms

https://github.com
0 stars 0 forks source link

Code Lab Feedback #1

Open zacharyweston opened 8 years ago

zacharyweston commented 8 years ago

Hey @chrisvfritz, can you take a look at this? It's hosted here and meets the following project criteria:

chrisvfritz commented 8 years ago

Nice Better Off Ted reference. :smiley: A few notes:

Transition on table scale

When hovering over the table, it looks like it grows larger, but it snaps to that size rather than slowly transitioning. See if you can fix that.

Consistent browser prefixes

In order to support Internet Explorer 9 and older iOS and Android, let's use the same vendor prefixes you're using here for transform.

In case you're curious, the reason browser prefixes aren't included in animate.css is because they're using a tool called autoprefixer. It automatically add prefixes where you need to for the browsers you want to support. We'll be diving into that tool in a later lesson, but for now, we need to add the prefixes manually.

Removing .DS_Store files from git

It looks like a .DS_Store file snuck into this repository. That's a hidden file that OS X automatically generates in folders managed by Finder. Since they have more to do with your computer than the project though, let's remove them from the project.

Check out this question on Stack Overflow for instructions on banishing those .DS_Store files forever!

zacharyweston commented 8 years ago

.DS_Store file has been removed, extra browser prefixes have been removed, and the table hover transition has been added. New URL is succinct-minute.surge.sh

chrisvfritz commented 8 years ago

YES! Looks great now. :ship: it (aka :shipit:). :stuck_out_tongue: