Code Lab Feedback - Githubissues

zacharyweston / codelab-js-booleans-and-comparators

https://github.com

0 stars 0 forks source link

Code Lab Feedback #1

Open zacharyweston opened 8 years ago

zacharyweston commented 8 years ago

Hey @chrisvfritz, can you take a look at this? It's hosted here and meets the following project criteria:

[x] include at least 2 choices for the user to make
[x] use prompt to collect choices from the user (the entire story can take place in dialog boxes, so your body element could be empty for this project)
[x] use comparators with if and else to branch the story, depending on user choices
[x] don't get too carried away - it can be tempting to build a complex video game, but remember, you can always come back and build on this project once you learn more

chrisvfritz commented 8 years ago

Nice easter egg reference to Douglas Adams. :smiley: The JavaScript code looks great, but I do notice a couple HTML errors:

This first line declaring the doctype has a typo. The exclamation point comes before DOCTYPE rather than after.
Nothing should be directly inside an html tag apart from the head and body. A script tag is a rare element that can actually go into either, though most typically at the very end of the body, so I would move your script tag there.

zacharyweston commented 8 years ago

Got it, so typically the script would just be in a separate file, right? I updated the code and pushed it, and the new URL is http://uneven-level.surge.sh/

chrisvfritz commented 8 years ago

Yes, all the JavaScript in most websites will be in a separate file. For this lesson though - and especially considering that the JavaScript is the app - inline is just fine.

And... everything looks perfect now! :shipit: