Code Lab Feedback - Githubissues

zacharyweston commented 8 years ago

Hey @chrisvfritz, can you take a look at this? It's hosted here and meets the following project criteria:

[x] The code from the previous Sinatra project is copied into this project folder
[x] You have more than one view file served to more than one route
[x] A .css and .js file are included on every page via a link and script element, respectively (make sure those files have some effect on the page so that we know it worked)
[x] A layout.erb file is used to DRY up your HTML
[x] There are not any unnecessarily duplicated lines of code between view files

chrisvfritz commented 8 years ago

Try viewing the source for the generator page in your browser. We have some page-ception going on. :stuck_out_tongue_winking_eye:

zacharyweston commented 8 years ago

HTML has been updated on the generator page, with same host. New code has been pushed.

chrisvfritz commented 8 years ago

It looks like both pages are still returning validation errors. Here are some specific points to help you clean those up:

It seems you're duplicating some HTML elements that are already in your layout file (like the head) in generator.erb.
It looks like this img still isn't quite valid HTML. The value of the src attribute doesn't have any quotes around it and then the img tag is never closed with a >.

Remember to check each page on validator.w3.org to make sure your HTML is valid!

And some other notes:

From a user experience perspective, shouldn't people put in their phone number if the submit button for the form says "Call Me. Please."? :stuck_out_tongue_winking_eye:
If we want the form to send to the person who created the profile, let's collect an email address from them and set up the form so that it sends to them instead of you.

Let me know if you have any questions! :smiley:

chrisvfritz commented 8 years ago

zacharyweston / codelab-sinatra-assets-and-layouts