search

zachbr / Dis4IRC

A modern Discord <-> IRC bridge
MIT License
51 stars 17 forks source link

Support threads #58

Open Phoenix616 opened 3 years ago

Phoenix616 commented 3 years ago

Discord is rolling out a new feature called "Threads". Simply forwarding new messages from them (maybe with some thread ID in the message?) should be enough imo.

I assume JDA needs to add support first though :S

Codixer commented 3 years ago

JDA is working on this as told in the JDA Discord, but there is no idea how long this will take.

zachbr commented 3 years ago

Thanks - was trying to wrap my head around the best way to deal with this as well. My original thought was just to treat threads similarly to how we handle replies currently. So we'd just include the additional context of the previous message (n-1) with the latest message in that thread (n). A thread ID might work better but I'm not sure.

Honestly, bridging this sort of thing to IRC is never going to be ideal I suspect. If some guild makes a ton of threads under a channel then it also won't scale well. I guess we'll just have to try it and see once JDA adds support.

Codixer commented 3 years ago

Yeah, that's going to be a fun story @zachbr. JDA is working on this, but as told in their discord. For this to work, they have to rewrite the plugin to JDA v5 to support all the new features. And moving to discord api v9. So this is going to bring A LOT of deprication problems.

Phoenix616 commented 3 years ago

Well the JDA v5-threads branch seems to have some recent activity which could enable this and Javacord now also supports it :eyes: (but I would hope JDA v5 addresses some of the issues that I see with the overall JDA design which made me choose Javacord instead so I doubt I need to push this project to another library too)