search

zachcurry / emacs-anywhere

Configurable automation + hooks called with application information
MIT License
1.08k stars 49 forks source link

Do not hardcore installation directory #59

Open cyruseuros opened 5 years ago

cyruseuros commented 5 years ago

This would make it possible to just add it to path from anywhere, and it would even be possible to set up with straight.el and use-package. This kind of makes sense as it is strictly an emacs-related plugin so it should be configurable inside .emacs.d. It wouldn't be the first time that non-elisp stuff went into an Emacs package (e.g. tide and it's tsserver directory)

zachcurry commented 5 years ago

Howdy, @jjzmajic! While I fancy myself a hardcore dude, I try not to hardcore my Emacs gang; that's not how I try to live my life, and I appreciate you bringing this to our attention. I’ve been keeping myself busy with other matters, so I call upon my Emacs gangsters (e.g., you) to fire a pull request my way, lest we be disgraced by too many open issues.

Go with Emacs, Z

cyruseuros commented 5 years ago

You got it! Expect one by the end of the week. You open to also including a use-package config example in the wiki?

zachcurry commented 5 years ago

@jjzmajic, If you do this, you will be the first to make a significant pull request to this repository, a real @#$*ing legend! An example in the README would be a great addition, and I'm all for it. The only things we need to keep in mind is that this is a cross-platform plugin (i.e., it has to work on both platforms), and we will need to think about how to deal with the existing install directory (e.g., Do we look for it and prompt to delete it? Do we just mention it in the README?). But, you seem like a sharp E-gangster and I'm sure you'll do an awesome job! I'll make time to read your PR and help you test when you're ready. Take your time, and go with Emacs.