zachcurry / emacs-anywhere

Configurable automation + hooks called with application information
MIT License
1.08k stars 49 forks source link

Use XDG home and add colour #69

Closed tecosaur closed 3 years ago

tecosaur commented 4 years ago

This closes #38, and makes the script nicer to look at.

image

zachcurry commented 4 years ago

Thanks for this, @tecosaur! I will look this over as soon as I get a chance.

tecosaur commented 4 years ago

@zachcurry I hope you get a chance soon :)

tecosaur commented 3 years ago

@zachcurry maybe around the Christmas holidays, you might have a little spare time? :eyes:

tecosaur commented 3 years ago

Hi @zachcurry :slightly_smiling_face: I tried sending you an email (using your git commit address) two weeks ago.

It would be great to hear if you've recieved it.

tecosaur commented 3 years ago

I've done a little re-implementation of the ideas here, tecosaur/emacs-everywhere.

As such, I now consider this PR redundant.

psibi commented 3 years ago

@tecosaur Note that I have another fork which uses a different clipboard mechanism that the one used here: https://github.com/psibi/emacs-everywhere

tecosaur commented 3 years ago

I see, you just type the contents. I'm not sure how well it would work for large buffers, but seems reasonable. With a bit of extra work, the clipboard approach is working consistently for me though.

psibi commented 3 years ago

So far I haven't had any issues. :-) But the problem I had with the old approach was:

Eitherwise, let me know if you do change the clipboard approach or make it configurable to add additional approaches. I would like to avoid relying on my fork if possible. :-)

tecosaur commented 3 years ago

In my rewrite, most of emacs-everywhere-finish is clipboard-related, but you could just add advice to replace that function. Another thought, I could check the clipboard contents immediately before overwriting, and then restore the clipboard content to that original state. Assuming you're on Linux, I'd be curious to know if you still have the reliability issues with my package, if you'd be willing to test it out and let me know that would be great :)

psibi commented 3 years ago

@tecosaur Sure, I will give it a try in a couple of days. I will open an issue in your issue tracker in case if something doesn't work. Thanks you!

tecosaur commented 2 years ago

let me know if you do change the clipboard approach or make it configurable to add additional approaches

I've recently pushed https://github.com/tecosaur/emacs-everywhere/commit/d20adad4b43c36c2d0b53630f09d3948cac2a916 which introduces some new defcustoms:

This may be enough, and if not I'm open to a PR adding support for further customisation.

psibi commented 2 years ago

@tecosaur I gave this a try today and it doesn't seem be working in my setup. This was my session:

❯ emacsclient --eval "(emacs-everywhere)"
nil

~/Downloads via 🦀 v1.57.0
❯

As you can see that it didn't put anything in my terminal after pressing C-x 5 0. Probably I should open an github issue instead ?