Closed marinakr closed 5 years ago
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/zachdaniel/git_ops/pulls/11.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/mix/tasks/git_ops.release.ex | 17 | 22 | 77.27% | ||
<!-- | Total: | 27 | 32 | 84.38% | --> |
Totals | |
---|---|
Change from base Build 69: | 2.3% |
Covered Lines: | 166 |
Relevant Lines: | 190 |
Thank you so much for all the cleanup you did in addition to this PR. Great stuff! I had one stylistic piece of feedback, but aside from that this looks great. I'll approve/merge once that change is made (or if you disagree with it feel free to discuss).
One more thing, if you could just remove the version change, as well as changes to the changelog. My workflow is to do the release and generate the changelog after merging the PR. Thanks!
done
Contributor checklist
fix: Multiply by appropriate coefficient
, orfeat(Calculator): Correctly preserve history
Any explanation or long form information in your commit message should be in a separate paragraph, separated by a blank line from the primary message