zachdaniel / git_ops

A tool for version and changelog management in Elixir via conventional commits.
MIT License
130 stars 21 forks source link

allow no prefix + pass credo #11

Closed marinakr closed 5 years ago

marinakr commented 5 years ago

Contributor checklist

sourcelevel-bot[bot] commented 5 years ago

Ebert has finished reviewing this Pull Request and has found:

You can see more details about this review at https://ebertapp.io/github/zachdaniel/git_ops/pulls/11.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 75


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/mix/tasks/git_ops.release.ex 17 22 77.27%
<!-- Total: 27 32 84.38% -->
Totals Coverage Status
Change from base Build 69: 2.3%
Covered Lines: 166
Relevant Lines: 190

💛 - Coveralls
zachdaniel commented 5 years ago

Thank you so much for all the cleanup you did in addition to this PR. Great stuff! I had one stylistic piece of feedback, but aside from that this looks great. I'll approve/merge once that change is made (or if you disagree with it feel free to discuss).

zachdaniel commented 5 years ago

One more thing, if you could just remove the version change, as well as changes to the changelog. My workflow is to do the release and generate the changelog after merging the PR. Thanks!

marinakr commented 5 years ago

done