fix!: fail on prefixed `!` and support postfixed `!`

zachdaniel / git_ops

A tool for version and changelog management in Elixir via conventional commits.

MIT License

134 stars 24 forks source link

fix!: fail on prefixed `!` and support postfixed `!` #22

Closed zachdaniel closed 4 years ago

zachdaniel commented 4 years ago

Contributor checklist

[x] My commit messages follow the Conventional Commit Message Format For example: fix: Multiply by appropriate coefficient, or feat(Calculator): Correctly preserve history Any explanation or long form information in your commit message should be in a separate paragraph, separated by a blank line from the primary message
[x] Bug fixes include regression tests
[x] Features include unit/acceptance tests

zachdaniel commented 4 years ago

@djantea this should address your issue, if you want to take a look at it. If its all good, I'll get it merged shortly. Great catch, much appreciated!

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 94

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 87.047%

Totals
Change from base Build 92:	0.5%
Covered Lines:	168
Relevant Lines:	193

💛 - Coveralls

djantea commented 4 years ago

@zachdaniel it looks good to me. Thank you!