fix: Fix tag order from git tag function.

zachdaniel / git_ops

A tool for version and changelog management in Elixir via conventional commits.

MIT License

130 stars 20 forks source link

fix: Fix tag order from git tag function. #30

Closed asummers closed 4 years ago

asummers commented 4 years ago

This list of tags comes in ABC sorted according to git, whereas the last_valid_non_rc_version function assumed it would come in tag revision order. This manifests itself in finding e.g. 9.9.0 as the latest revision when 10.0.0 is in the list of tags, as well. Because this tag is used later to calculate the diff, it winds up double counting commits and therefore doing bumps it should not be.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 108

4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 85.507%

Files with Coverage Reduction	New Missed Lines	%
lib/git_ops/git.ex	1	35.0%
<!--	Total:	1		-->

Totals
Change from base Build 105:	0.1%
Covered Lines:	236
Relevant Lines:	276

zachdaniel / git_ops

fix: Fix tag order from git tag function. #30

Pull Request Test Coverage Report for Build 108

💛 - Coveralls