search

zachfeldman / rubypress

Ruby interface for the WordPress XMLRPC API. Follows standard XML-RPC Documentation closely.
201 stars 55 forks source link

Remove support for ruby 1.9.2 #26

Closed punkle closed 10 years ago

punkle commented 10 years ago

Removing support for ruby 1.9.2.

seuros commented 10 years ago

why ?

zachfeldman commented 10 years ago

We can't use VCR to run the test suite in 1.9.2 thanks to a URI parsing error so I told @punkle to remove it in future versions. It can be "unofficially supported" in that the library should still mostly work in 1.9.2.

seuros commented 10 years ago

Nope s.required_ruby_version = '>= 1.9.3' <=

zachfeldman commented 10 years ago

What do you mean @seuros ? The Ruby version must be greater than or equal to Ruby 1.9.3, which is what we wanted?

punkle commented 10 years ago

@zachfeldman I have no reason to believe that rubypress will not work with ruby 1.9.2. Also, the pull request https://github.com/zachfeldman/rubypress/pull/25 which I created to fix the tests for 1.9.2 also fixes a bug for all versions of ruby.

Sorry for the confusion, If you need more detail let me know..

seuros commented 10 years ago

I don't think it worth supporting anything belove 1.9.3. Even 1.9.3 entered it EOL phase.

punkle commented 10 years ago

I agree. However pr #25 will fix an issue running in all versions of ruby and as such should merged regardless of whether 1.9.2 is being supported. If that is not clear let me know.

If that pr is chosen to be merged, in theory, the 1.9.2 tests will pass. Therefore giving rubypress unofficial 1.9.2 support for nearly no effort. The only effort being: enabling the running of the tests in Travis (non failing); and changing the gemspec back to include 1.9.2. On 13 Sep 2014 20:21, "Abdelkader Boudih" notifications@github.com wrote:

I don't think it worth supporting anything belove 1.9.3. Even 1.9.3 entered it EOL phase.

— Reply to this email directly or view it on GitHub https://github.com/zachfeldman/rubypress/pull/26#issuecomment-55503912.

seuros commented 10 years ago

I don't see a reason why #25 should not be merged. LGTM :shipit:

zachfeldman commented 10 years ago

Merged it!

zachfeldman commented 10 years ago

Now the build is broken:

https://travis-ci.org/zachfeldman/rubypress/builds/35267583

punkle commented 10 years ago

Hey,

Best thing to do is revert, if possible, and I'll look at it later. Sorry about that.

Brian On 14 Sep 2014 17:41, "Zach Feldman" notifications@github.com wrote:

Now the build is broken:

https://travis-ci.org/zachfeldman/rubypress/builds/35267583

— Reply to this email directly or view it on GitHub https://github.com/zachfeldman/rubypress/pull/26#issuecomment-55531192.

zachfeldman commented 10 years ago

I haven't published a new version of the gem with these changes yet so it's no worries. Thanks for taking a look when you get the chance @punkle !