search

zachfeldman / rubypress

Ruby interface for the WordPress XMLRPC API. Follows standard XML-RPC Documentation closely.
201 stars 55 forks source link

Since ruby 2.4.0 gem 'xmlrpc' needed #54

Closed mysticaltech closed 7 years ago

mysticaltech commented 7 years ago

Just to signal that since ruby 2.4.0 we now need gem 'xmlrpc' to this work, maybe require it automatically ?

zachfeldman commented 7 years ago

Cool, I no longer use this gem actively in any projects so feel free to submit a pull request!

mysticaltech commented 7 years ago

I tried adding gem 'xmlrpc' just after gemspec in the Gemfile https://github.com/rimkashox/rubypress/blob/master/Gemfile, but didn't work.. I still get the same error active_support/dependencies.rb:293:in require: cannot load such file -- xmlrpc/client (LoadError)

But it does go away when I require directly the gem in my rails Gemfile...

Any idea ? I'm sure the solution is a one liner..

zachfeldman commented 7 years ago

Hey, are you sure you required the library after adding the gem/followed the instructions on the gem repo? https://github.com/ruby/xmlrpc

mysticaltech commented 7 years ago

Hey Zach, yep this is required already by you in rubypress.rb, I just needed to add s.add_dependency 'xmlrpc' to the gemspec file. Sending in a pull request now, I let you do the version change if necessary.

zachfeldman commented 7 years ago

New version pushed!

zachfeldman commented 7 years ago

Thanks again @rimkashox .

mysticaltech commented 7 years ago

My pleasure!