Closed fotos closed 12 years ago
Is there something you didn't like in the proposed patch that I should fix or you just didn't have enough time to review and pull the patch in?
:up:
+1
+1
+1
+1
+1
+1
+1
+2
+1
@zachinglis Could you merge it plz?
+1
I've been mixed on this, because I feel like it's up to the user to decide whether to safe it or not. But due to the overwhelming response of people wanting this in… I'm up for it.
@zachinglis thanks for pulling this in.
For the record, it's still up to the user to decide. If he passes in a html_safe string we don't make it unsafe. In other words we don't change the safeness of the string. We just keep it the way it was. The problem was that all strings returned by the block became unsafe by default and there was nothing you could do by the time #content_tag was called (where the HTML was escaped). That's what this patch fixed. Hope this clears it up.
Thanks @zachinglis and @fotos!
Hey,
a patch for the problem described here: https://github.com/zachinglis/crummy/commit/ec82d85dacad3879ae4462a2e13106c395903622#commitcomment-974228
Hopefully it's straightforward enough to understand the change. :)
-fotos