zachinglis / crummy

Tasty breadcrumbs! Crummy is a simple and tasty way to add breadcrumbs to your Rails applications.
http://zachinglis.com
MIT License
358 stars 82 forks source link

Added a four features to render_crumb #53

Closed bsa7 closed 11 years ago

bsa7 commented 11 years ago

Hi all! Four features added. 1. Now, we can set each parameters individually for each crumb. example:

add_crumb name, link, :li_class => "my_class"

2. Not render empty html_options for tags. example: in rendered output we have no tag class instead class="" issue 35 solved 3. We can set each crumb on right or left side. That parameter :right_side define it. example:

add_crumb support_link, {:right_side => true, :links => "/support", :li_right_class => "pull-right hidden-phone"}

4. Also, we can use a html in a crumb name. No more results as:

<a href="\"><a style"...">...</a></a>

when call:

add_crumb '<a style="...">Some text</a>'

but will be carefully, you are need to pass href parameter in a tag for a link.

andrew commented 11 years ago

Looks good, can you update the tests as well?

bsa7 commented 11 years ago

Yes, i work on this problem.

bsa7 commented 11 years ago

OK. Test updated and passed.

andrew commented 11 years ago

Excellent, thanks!

andrew commented 11 years ago

I'll try and get a new release out later today

bsa7 commented 11 years ago

OK. I'm ready to work on possible bugs, send me a mail, if issues found. With best regards, Sergeij Belevskij Tobolsk Russia

2013/10/20 Andrew Nesbitt notifications@github.com

I'll try and get a new release out later today

— Reply to this email directly or view it on GitHubhttps://github.com/zachinglis/crummy/pull/53#issuecomment-26675322 .

andrew commented 11 years ago

I've just published this as v1.8.0: https://rubygems.org/gems/crummy/versions/1.8.0

bsa7 commented 11 years ago

Andrew!

2013/10/20 Andrew Nesbitt notifications@github.com

I've just published this as v1.8.0: https://rubygems.org/gems/crummy/versions/1.8.0

— Reply to this email directly or view it on GitHubhttps://github.com/zachinglis/crummy/pull/53#issuecomment-26676660 .

bsa7 commented 11 years ago

Andrew! I'm glad to see this gem has updated.

2013/10/20 Andrew Nesbitt notifications@github.com

I've just published this as v1.8.0: https://rubygems.org/gems/crummy/versions/1.8.0

— Reply to this email directly or view it on GitHubhttps://github.com/zachinglis/crummy/pull/53#issuecomment-26676660 .