zachinglis / crummy

Tasty breadcrumbs! Crummy is a simple and tasty way to add breadcrumbs to your Rails applications.
http://zachinglis.com
MIT License
358 stars 82 forks source link

Simplify and improve Crummy::StandardRenderer #60

Closed blaknite closed 7 years ago

blaknite commented 9 years ago

I've made quite a few changes and improvements to Crummy. Most notably is a fix to a XSS bug that occurs if your crumb's name is derived from user-entered data. Adding html_safe to strings so liberally is bad.

In the process of making these changes I did drop the microdata support due to the spec being abandoned. I didn't have much need or desire to implement the new spec.

Here's a run-down of what has changed. Pick and choose as you wish.

blaknite commented 7 years ago

I finally come back and revisited this branch two years later because I'm still using the gem in quite a few projects. Currently what I have done has no support for microdata and some options are removed. I'll be patching it up to remove the regressions.

Tests currently pass locally for what I've done but there's a bundle issue on travis :(