Improve reddit post display

zachkont / dotaUpdatesBot

A telegram bot for dota2 updates

GNU General Public License v3.0

23 stars 23 forks source link

Improve reddit post display #37

Closed TimJentzsch closed 6 years ago

TimJentzsch commented 7 years ago

Currently, everything gets previewed twice, first as code text preview and then as link preview. The link one looks a bit better in my opinion, but doesn't remove the formatting strings, the code text preview contains unimportant information from reddit, such as submitted by /u/SirBelvedere to r/DotA2 [link] [comments].

So one of them should be removed and improved accordingly.

Screenshots: Sir Belvedere

wykrhm

zachkont commented 7 years ago

True

BenHargreaves commented 6 years ago

Taking a look at this now and it seems to be a pretty quick fix.

The 'Link' preview is generated by the Telegram itself I believe so not much we can do there, but the 'Code' message can be stripped of the 'Submitted by ....' fairly easily. I can have a PR up for review after work today :)

BenHargreaves commented 6 years ago

Created PR #57 to address this. Let me know if I need to change anything

zachkont commented 6 years ago

Looks good, merged