search

zachleat / speedlify

Benchmark the web performance and accessibility of sites over time.
https://www.speedlify.dev/
MIT License
930 stars 167 forks source link

Documentation lacking #32

Closed httpsterio closed 4 years ago

httpsterio commented 4 years ago

I tried to find how the actual lists are sorted (ie. how the scores are weighted and compared against each other) and didn't really find it mentioned anywhere and I couldn't figure it out just by reading the code either. Any clarification possible?

zachleat commented 4 years ago

Ah yeah sorry the docs for this are not great yet! More info here https://www.zachleat.com/web/eleventy-leaderboard-speedlify/#“the-algorithm”-and-tiebreaker-changes

httpsterio commented 4 years ago

Alright, thanks for the clarification! I do understand why page weight plays into it but it feels counter intuitive that FCP and LCP don't factor in before page weight as currently this means that if the page hits 100s on Lighthouse and has no axe violations you should just increase the page size instead of optimizing the CSS and HTML and server settings.

Wouldn't it make more sense if the total blocking time would come before weight?

zachleat commented 4 years ago

I think it would make even more sense to allow a configuration option on performance-leaderboard specifically to feed in your own algorithm! Feel free to file an enhancement request over there!

zachleat commented 4 years ago

Sorry, here’s the thing https://github.com/zachleat/performance-leaderboard

zachleat commented 4 years ago

I’m operating under the assumption that you want to customize this for your own leaderboards, not submit that the Eleventy Leaderboard algorithm be changed. Let me know if that’s wrong!