search

zachleat / speedlify

Benchmark the web performance and accessibility of sites over time.
https://www.speedlify.dev/
MIT License
929 stars 167 forks source link

Remove _data/sites/*.js "default" files from repository for easer fork install/update #37

Open nhoizey opened 3 years ago

nhoizey commented 3 years ago

Every time I try to update my fork, I get back the _data/sites/*.js from this repository, and most of the times, I forgot to remove them and have (at least) one big build on Netlify. 😅

It would be easier if these files where in a _data/sites-sample/ folder, and speedlify would alert if there is no _data/sites/*.js yet.

You @zachleat could then copy _data/sites-sample/ to _data/sites/ in your own fork running on Netlify.

It would be much easier for anyone else using speedlify for their own needs, but I agree it would be less easy for you @zachleat to manage both this and a fork, though. 🤷‍♂️

TigersWay commented 3 years ago

I thought skip: !process.env.CONTEXT || process.env.SITE_NAME !== "speedlify" was there just for that purpose...

nhoizey commented 3 years ago

Hum… my process must be broken then, I'll try once again and report if this work as intended!

nhoizey commented 3 years ago

Ok, I think my fork update was a little too extreme, it removed my own personal sites configurations… 🤦‍♂️

How do you update yours?

I was also reading "After cloning you’ll probably want to delete the initial _data/sites/*.js files and create your own file with a list of your own site URLs!" in the README and jumped to a bad conclusion.

TigersWay commented 3 years ago

All _data/sites/*.js but the sample one have that skip flag... I believe I used that one the first time 😄 Then I added new ones. @zachleat's original files are still there.

nhoizey commented 3 years ago

Looks like you're right, the "The default sites that get tested" is active by default, we have to remove it: https://webperf-monitoring.netlify.app/

image