search

zachleat / speedlify

Benchmark the web performance and accessibility of sites over time.
https://www.speedlify.dev/
MIT License
929 stars 167 forks source link

"Deploy to Netlify" fails — NodeJS version < 14? #47

Closed davidhund closed 2 years ago

davidhund commented 2 years ago

"Deploy to Netlify" seems broken.

The Netlify Deploy fails run-tests with a SyntaxError because NodeJS 12 does not support the ?. Optional chaining operator:

image

There are many warnings before this, specifically:

npm WARN notsup Unsupported engine for lighthouse@9.1.0: wanted: {"node":">=14.15"} (current: {"node":"12.22.7","npm":"6.14.15"})

It seems the latest "performance-leaderboard": "^9.0.0" requires lighthouse ^9.0.0 which, in turn, requires NodeJS >= 14.15 but Netlify is running NodeJS 12.

I cannot see where we can/should update the NodeJS version Netlify Deploy should be using...

davidhund commented 2 years ago

FYI: I fixed this by changing NodeJS version 12 to 16 in my fork's .nvmrc

zachleat commented 2 years ago

Updated this, thanks!