search

zachleat / speedlify

Benchmark the web performance and accessibility of sites over time.
https://www.speedlify.dev/
MIT License
922 stars 168 forks source link

Rename _data/sites.js to _data/sites-sample.js #7

Closed nhoizey closed 4 years ago

nhoizey commented 4 years ago

When updating a fork, _data/sites.js should be the only file with legitimate changes to keep, so renaming it to _data/sites-sample.js in the source repository would allow easier forks updates.

Speedlify could look for sites-sample data if there is no sites data, and add a big notification in the UI (like Eleventy's documentation button… 😅) to invite people to create their own sites.js file.

nhoizey commented 4 years ago

You could even not look for sites-sample data, if you don't want everyone to check Netlify pages… 😅

zachleat commented 4 years ago

Hmm. HMM. This is all I have to say right now hmm—not sure I like that but I’m not the one feeling the pain of the conflicts 😅

nhoizey commented 4 years ago

Hmm. HMM.

I'll take that for now… 😅

We can wait for additional feedback from other users.

davidbgk commented 4 years ago

I agree that it would ease the pain of merging to keep the code in sync when forking. It would probably require a changelog, at least for that file though.

zachleat commented 4 years ago

I pushed a change to speedlify that will help here and probably will be good enough to close this one. Each category/vertical is now a separate file in _data/sites/*.js so we shouldn’t see conflicts here moving forward unless you have the same categories as me 👍🏻

nhoizey commented 4 years ago

This is even better! 👍