search

zachmayer / caretEnsemble

caret models all the way down :turtle:
http://zachmayer.github.io/caretEnsemble/
Other
226 stars 75 forks source link

Check functions #106

Closed zachmayer closed 9 years ago

zachmayer commented 9 years ago

Closes #45 and #105

zachmayer commented 9 years ago

@jknowles This PR is ready for review too. Test pass locally and on travis. I think this clears up everything we need for CRAN release except the test data cleanup you're working on!

jknowles commented 9 years ago

This looks good to me. Merge it in when you want, I'll rebase against this and submit a small PR to fix up the rest either later today or Monday. Then we can submit. :+1:

zachmayer commented 9 years ago

I made change based on your comment, will merge as soon as tests pass.

zachmayer commented 9 years ago

travis time out lol. Gonna merge and see what happens.