search

zachmayer / caretEnsemble

caret models all the way down :turtle:
http://zachmayer.github.io/caretEnsemble/
Other
226 stars 74 forks source link

Params is set but never used #108

Closed nkurz closed 9 years ago

nkurz commented 9 years ago

https://github.com/zachmayer/caretEnsemble/blob/f420171ef086a52bdb02dea8fbe64d05be782ad8/R/caretList.R#L11

caretModelSpec <- function(method='rf', ...){ stopifnot(is.character(method)) params=list(...) out <- c(list(method=method), list(...)) return(out) }

Probably no difference in result, but it looks like something was left behind after an edit. Change the second occurrence of 'list(...)' to 'params'? Skip the line setting 'params'?

zachmayer commented 9 years ago

Thanks for the report. See PR #110