Major test re-factor - Githubissues

zachmayer / caretEnsemble

caret models all the way down :turtle:

http://zachmayer.github.io/caretEnsemble/

Other

226 stars 74 forks source link

Major test re-factor #121

Closed zachmayer closed 3 months ago

zachmayer commented 9 years ago

Test principles:

[x] No tests depend on data from non-cran packages
[x] All datasets are moved to inst/data-raw and inst/testdata
[x] Huge test_that() blocks are re-factored into smaller, more atomic modules
[x] Longer running tests are marked skip_on_cran()
[x] Tests covering most essential functionality still run on CRAN.

jknowles commented 9 years ago

@zachmayer

I don't think the datasets I supplied depend on non-cran packages. They can't be generated automatically with the test-data script, but that isn't a requirement of CRAN or anything -- they can just be bundled with the package and saved in inst/testdata and imported from there.

I think the package currently does this.

zachmayer commented 9 years ago

Gotcha. So we're allowed to just include the data? That certainly simplifies things lol.

jknowles commented 9 years ago

Yes. I think the idea is you can include a published dataset that was collected and not just synthetic datasets that can be generated by R.

zachmayer commented 3 months ago

tests are refactored, while maintaining 100% coverage: https://github.com/zachmayer/caretEnsemble/pull/308