search

zachmayer / caretEnsemble

caret models all the way down :turtle:
Other
226 stars 75 forks source link

\dontrun{} some examples #126

Closed zachmayer closed 9 years ago

zachmayer commented 9 years ago

The problem with this is when you run example() on these functions, nothing will run now. But they’ll all be skipped on CRAN, so we won’t get complaints about example run times from the CRAN maintainer.

We can shorten them all further (is this even possible) and then gradually remove \dontrun{}

zachmayer commented 9 years ago

@jknowles I'd love to see your feedback on this. I'm not 100% sure the CRAN comments we got necessitates it, but I'm being conservative.

jknowles commented 9 years ago

These look good to me. I am a big fan of not running examples on CRAN. I understand the goal is to make sure they actually work, but we can do that separately. With a good unit testing structure in place that should be fine. A package like this is more resource intensive, so CRAN machines are probably very atypical from what our user base will be using anyway -- getting them to run on CRAN in a reasonable time does not seem that helpful.

zachmayer commented 9 years ago

Great. Merging!