search

zachmayer / caretEnsemble

caret models all the way down :turtle:
Other
226 stars 75 forks source link

caret 6.0-64 breaks caretEnsemble #180

Closed zachmayer closed 8 years ago

zachmayer commented 8 years ago

Email from max:

I made some changes to caret and it is violating one of the
caretEnsemble’s tests. I suspect that

   predict(mod)

is being used without `newdata`. I’ve attached the current version. Can
you confirm?
Mosquito00 commented 8 years ago

Hello zachmayer,

Thank you.

Where can we find the new version?

zachmayer commented 8 years ago

Master branch here: https://github.com/topepo/caret/tree/master/pkg/caret

zachmayer commented 8 years ago

This commit for future reference: https://github.com/topepo/caret/tree/c2745556371c69d4ed62c560c45647702c604c82/pkg/caret

zachmayer commented 8 years ago

Fix is here: https://github.com/zachmayer/caretEnsemble/pull/181

zachmayer commented 8 years ago

Actually that fix may not fix the new issue. We'll see.

jknowles commented 8 years ago

I don't think that'll fix the issue @zachmayer. I think the error is in some of my tests. Let me pull it down and see what I can change.

zachmayer commented 8 years ago

@jknowles Yeah, I think this fixes a different issue. I think it's time to clean up and do a new CRAN release.

jknowles commented 8 years ago

Agreed. I'll work on fixing the unit tests and send a PR soon. Then we can think about anything else we should do pre-release.

jknowles commented 8 years ago

@zachmayer I think this might be localized to an issue with predict.gbm -- I'm testing that theory now.