zachmayer / caretEnsemble

caret models all the way down :turtle:
Other
226 stars 75 forks source link

add functions for concatenating caretList and train #183

Closed JasonCEC closed 8 years ago

JasonCEC commented 8 years ago

S3 Generic for concatenating caretList and train objects for use in caretEnseble

Closes #136

zachmayer commented 8 years ago

:+1: On an initial review. Our travis builds are broken right now (:sob:), so ignore the travis error.

JasonCEC commented 8 years ago

Woot! I tried to write a few tests for the new functions... I had a bit of difficulty figuring out if errors in the tests were my mistakes or things left to be fixed in the next major / minor release. I'm happy to update and fix anything in this pull request, and could probably jump on anything that needs an immediate fix to keep the package functioning!