search

zachmayer / caretEnsemble

caret models all the way down :turtle:
http://zachmayer.github.io/caretEnsemble/
Other
226 stars 75 forks source link

Draft of intro vignette #49

Closed zachmayer closed 9 years ago

zachmayer commented 9 years ago

In response to issue #40. Please give any feedback here, and feel free to write your own vignette (or expand this one!)

zachmayer commented 9 years ago

@jknowles If this vignette looks cool to you, I'm going to merge it. Tests are passing now, including for re-building the document. You can view the draft vignette here, leave me any comments you have on grammar, style, etc

jknowles commented 9 years ago

@zachmayer I'll note a few typos and then you can make changes and merge this in. This looks great. I learned a lot -- I never really understood caretStack myself before. Do we need a summary method for caretStack for version 1.0 as well?

Also, I like that model correlation plot a lot. I might include it as an option in autoplot.

jknowles commented 9 years ago

OK - typos noted. This looks great.

zachmayer commented 9 years ago

Glad you like it— I'll fix those. caretStack does need a summary method, but I was thinking for now we could just print out the ens_model when summary is called. Similarly, we can plot that model when plot is called.

Yeah, there's a ton of awesome plotting functions for collections of models build into caret. It's actually what originally gave me the idea for the package, as the plotting methods require the models have the same resamples, and once I was plotting lists() of caret models I started thinking: couldn't we ensemble these too?

jknowles commented 9 years ago

Well its good to know the origin story. The more I dig into this, the more ways I find to help communicate it out to users of the ensembled models in an understandable way.

zachmayer commented 9 years ago

@jknowles I updated the vignette to hi-light caretList and work with the new API. Please let me know what you think!

jknowles commented 9 years ago

Just see one small typo at the end that needs to be fixed. Gave it a line comment. Otherwise, this looks fantastic!

zachmayer commented 9 years ago

Great!  I'll fix and merge later today!

jknowles commented 9 years ago

That sounds great. I should have some optimization tests in place in a PR today. Then we should be very close to release!

zachmayer commented 9 years ago

I added a few more commits to clean up some examples and also remove exports from a few caretEnsemble functions. I'm going to go ahead and merge, but please let me know if you have any comments.

zachmayer commented 9 years ago

This will close #74, #64, #47, and #40