search

zachmayer / caretEnsemble

caret models all the way down :turtle:
http://zachmayer.github.io/caretEnsemble/
Other
226 stars 75 forks source link

grid.arrange to cleanup autoplot #76

Closed zachmayer closed 9 years ago

zachmayer commented 9 years ago

removes the functionality, but makes the plotting code faster and a bit more stable.

zachmayer commented 9 years ago

@jknowles I tried out a variant of your autoplot function and I like it. What do you think?

jknowles commented 9 years ago

Yes, I like that. I included the none grid.arrange here to avoid an import, but if you don't mind importing gridExtra, then this makes perfect sense and is much cleaner.

zachmayer commented 9 years ago

Hmmm, good point. I guess I lean slightly towards importing grid.arrange, as this is exactly the sort of problem it's designed to solve.

Also, my branch failed on travis— I'll have to fix it.

jknowles commented 9 years ago

Works for me -- I just thought it was bad etiquette to fill up a package with imports if you aren't the creator :new:

zachmayer commented 9 years ago

Hahahah, fair enough. If this passes travis, I'll go ahead and merge

zachmayer commented 9 years ago

Tests pass, huzzah!

Btw I'm on vacation for the next week, so I'll only be working sporadically.

zachmayer commented 9 years ago

oops, merge conflicts