zachmayer / caretEnsemble

caret models all the way down :turtle:

http://zachmayer.github.io/caretEnsemble/

Other

226 stars 74 forks source link

multiPredict becomescomes predict.caretList #92

Closed zachmayer closed 9 years ago

zachmayer commented 9 years ago

All our lists of caret models should be of class caretList. Then multiPredict simply becomes predict.caretList.

zachmayer commented 9 years ago

I've decided this really needs to be part of 1.0. multiPredict is a core part of the api, and I don't want people to start using that function in their own code. predict.caretList is sooooo much more elegant.

I'm working on the change now, I think it will be fairly straightforward. We'll see!

jknowles commented 9 years ago

I agree. I'll keep an eye on your changes and patch up any holes that come out from stuff I have done that gets in your way.

zachmayer commented 9 years ago

Sounds good! I think I have my branch in good shape— PR coming soon! (Just have to sort out some tests)

zachmayer commented 9 years ago

99 should close this

zachmayer commented 9 years ago

Closed by #99