zachmayer / caretEnsemble

caret models all the way down :turtle:
http://zachmayer.github.io/caretEnsemble/
Other
226 stars 74 forks source link

predict.caretList #99

Closed zachmayer closed 9 years ago

zachmayer commented 9 years ago

Streamline the API!

zachmayer commented 9 years ago

@jknowles I think is is ready for a review (assuming tests pass). It grew a little larger than I'd planned... in particular, there were some tests in test-optimizers.R that I couldn't fix and ended up commenting out. They were looking for degenerate cases and errors in greedOPT and safeOPT. Nothing I did should have changed those functions, so I'm not sure why they stopped working as expected.

Maybe the test data changed?

zachmayer commented 9 years ago

Should close #90 #91 and #92

zachmayer commented 9 years ago

:+1: