Consider which method we will use to store data

[zacholade]

Json? SQL? Personally i really dislike sql. not that it's bad, i just find it difficult to understand and don't really have time to learn the ins and outs....

I think storing data for each summoner in a json file (one per region) is best. If the bot does end up blowing up then sure.. we can consider others?

[TheSnoozer]

From what I know we have:

• SQL or any other database storage system
  • Pros: very scablable with huge amount of data, parallel read and write access to the same data
  • Cons: Requires a decent understand of SQL (possibly solvable with a wrapper like sqlalchemy (see https://www.pythoncentral.io/introductory-tutorial-python-sqlalchemy/) or any other wrapper (https://www.pythoncentral.io/sqlalchemy-vs-orms/)
• Json
  • Pros: scablable with big amount of data, very easy to use
  • Cons: parallel read and write access to the same data might become a headache
• Pickle
  • Pros: scablable with big amount of data, very easy to use
  • Cons: parallel read and write access to the same data might become a headache, serialization of random data needs extra handling

I think the question for what storage is the best, becomes the question if we need parallel read and write access. I would be fine with JSON, since it's very easy to read/write. But it becomes a headache when we for example want to somehow read and write in parallel (e.g. the prefix of the bot).

[zacholade]

https://github.com/Zachy24/Rift-Companion/commit/ce13b9ab61321de4d80a15214a4f69d8bb533df2

Ok. So sql is apparently op :P

[zacholade]

If you would be so kind to just check over my sql code here and make sure it doesnt appear to have any issues as my confidence is still questionable.. plus idk if anything could be sql injected here? Thanks dude @TheSnoozer