search

zachomedia / apple-music-webplayer

Web player for Apple Music (using MusicKit JS)
https://music.zacharyseguin.ca
MIT License
597 stars 76 forks source link

Seekbar feature #51

Closed jmaruiz closed 6 years ago

jmaruiz commented 6 years ago

Increased the size of the progress bar just a little and added a seek feature to it. Includes a tooltip to let users know what timestamp they are seeking to in the song. (Tooltip styled for light and dark theme)

zachomedia commented 6 years ago

Another improvement would be to look at rebasing against my current master (to prevent a bunch of extra commits). Not a big deal if you don't get it for this issue as I can fix it at merge time.

jmaruiz commented 6 years ago

I made the changes you suggested! Thanks for the guidance btw, I haven't used Vue before. I attempted the rebase, but I'm not sure I did it correctly. Looks messy. If you don't mind fixing it I will make sure any future pull requests start from the current master (or feel free to tell me where I went wrong and how to properly rebase).

zachomedia commented 6 years ago

This has been merged manually on the command line.

@jmaruiz Thanks for this! Rebasing can be tricky (and takes a bit of practice to get). Didn't help that there were other commits to the master branch today that caused a merge conflict when this PR was rebased against it.