Closed AurelienLoyer closed 5 years ago
Thanks for the report. What browser and OS are you experiencing this in? I was unable to reproduce in Safari and Chrome on macOS.
It's a know bug when you change Bitrate (Changing the bitrate will cause the page to reload.) Keep sound in localstorage or somethink like this will be cool :)
Yeah, changing the bitrate currently triggers a full reload because the bitrate setting is only writable when calling MusicKit.configure
.
I will look at saving current playlist + song in localstorage.
It was my first idea 👍
@zachomedia FWIW documentation is lacking for bitrate. You can set the bitrate without reloading, but it will not take effect until the next track is started.
MusicKit.getInstance().bitrate = MusicKit.PlaybackBitrate.HIGH
Thanks @jaehess. I'll update it then to change that value.
Just note, the docs do say that's a readonly
value (https://developer.apple.com/documentation/musickitjs/musickit/musickitinstance/2992702-bitrate).
When i change my settings, player reset current playing song. I'll be cool if current song whould be keeping 😊
PS: thx for your work. Just a awesome idea 👍 ! I'll make PR soon for features and bugs fixed !