zachomedia / apple-music-webplayer

Web player for Apple Music (using MusicKit JS)
https://music.zacharyseguin.ca
MIT License
597 stars 76 forks source link

On playing a song in a playlist it jumps to the next one #78

Open Simix2017 opened 5 years ago

Simix2017 commented 5 years ago

When I click on a song in a playlist, it jumps to the the song after the clicked one. This song plays normally and without errors. The forward/backward keys also work normally.

(Firefox 66.0.2, DRM-Support, Arch Linux, 5.0.4-arch1-1-ARCH, 64-Bit)

zachomedia commented 5 years ago

Thanks for the report.

I think I figured out what's causing this. There's some missing error handling when fetching ratings for songs (love/disliked), so I think it triggers the fallback handler which skips to the next song. I'll continue investigating and come up with a fix.

zachomedia commented 5 years ago

@Simix2017 I've pushed a fix that resolves it some of the time. Seems like something else causes it to skip ahead and it will require some further investigation.

relict007 commented 5 years ago

It seems to have gotten worse actually. Earlier it was just jumping to the next song but now it jumps to next song as well as shows wrong metadata (of the intended song) in the player.

zachomedia commented 5 years ago

I did some more investigation on this, and it looks like there's a bug with setting the starting position when configuring the play queue. I need to conduct a bit more testing and will likely have to submit this as a bug upstream.

For now though, I think I've found a work around that seems to resolve the issue. Please let me know if you continue to encounter the issue.

relict007 commented 5 years ago

Now it just jumps to the next song. Metadata seems to be correct on the player.

Simix2017 commented 5 years ago

Now the error is now longer occuring

jacobthehammer commented 5 years ago

I'm still experiencing this issue in Firefox 66.02

jacobthehammer commented 5 years ago

And it has suddenly started working as expected for me as well.

zachomedia commented 5 years ago

Great, thanks for the update.