search

zachomedia / cert-manager-webhook-pdns

A PowerDNS webhook for cert-manager
MIT License
59 stars 35 forks source link

fix: get proxy from env when using custom CA bundles #18

Closed Meallia closed 2 years ago

Meallia commented 2 years ago

Fixes #17

When creating the custom transport to use the provided CA bundle, no proxy configuration was provided. By default, the http.Client use the http.DefaultTransport with Proxy set to ProxyFromEnvironment.

Meallia commented 2 years ago

I went with the most simple approach, it might have been better to copy the default transport and only set the custom TLS config but I have no idea how to do that in go.