zachomedia / cert-manager-webhook-pdns

A PowerDNS webhook for cert-manager
MIT License
59 stars 35 forks source link

Set http/https proxy via env variables #47

Closed bbusioc closed 1 month ago

bbusioc commented 1 year ago

Hello,

Is there a was to set the http/s proxy via an environment variable by using the helm chart?
For some reason, which I can't really understand to reach the power DNS API I have to go through a proxy.
I manually edited the deployment, added the required HTTP_PROXY, HTTPS_PROXY and NO_PROXY configurations and it worked.
However, I can't find a way to set environment variables via the helm chart.

Thanks, Bogdan

bbusioc commented 1 year ago

I fixed it locally on my side by updating like this the env part in the deployment template:

          env:
            - name: GROUP_NAME
              value: {{ .Values.groupName | quote }}
            {{- with .Values.http_proxy }}
            - name: HTTP_PROXY
              value: {{ . }}
            {{- end }}
            {{- with .Values.https_proxy }}
            - name: HTTPS_PROXY
              value: {{ . }}
            {{- end }}
            {{- with .Values.no_proxy }}
            - name: NO_PROXY
              value: {{ . }}
            {{- end }}

But I think it would be great if this or a better solution could be integrated in your repo.

Thanks, Bogdan

zachomedia commented 1 year ago

Hello @bbusioc, thanks - I thought the chart supported arbitrary env vars, but it looks like it does not. I'll add that support soon.

stephbat commented 1 month ago

@zachomedia : when will it be possible for you to add env variables ?

stephbat commented 1 month ago

I sent this PR https://github.com/zachomedia/cert-manager-webhook-pdns/pull/54

zachomedia commented 1 month ago

Resolved via #54