zachowj / hass-node-red

Companion Component for node-red-contrib-home-assistant-websocket to help integrate Node-RED with Home Assistant Core
MIT License
465 stars 182 forks source link

Get this into core. #34

Closed frenck closed 3 years ago

frenck commented 4 years ago

Is your feature request related to a problem? Please describe.

Get this custom stuff into the core, and remove the need for users to install this custom component.

Describe the solution you'd like

See above

Describe alternatives you've considered

Deprecate the Home Assistant Node-RED add-on to get rid of this brain damage I've accumulated over time on users not able to figure this all out.

Additional context

No.

zachowj commented 4 years ago

If I recall correctly this wouldn't be a component accepted into the core as it communicates directly with an external source using a client-initiated WebSocket connection.

github-actions[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

frenck commented 3 years ago

Right, so it should become part of the core APIs in that case.

zachowj commented 3 years ago

I guess I should have been more clear. Not only does it communicate directly with Node-RED there are also custom sensors and switches that need to exist. So it more than some API endpoints.

frenck commented 3 years ago

Those would go into an core integration?

I'm failing to see the issue with that.

In the end, the thing that counts here, is that a lot of users don't have a clue what is going on and what to do.

This confusion caused a lot of frustration with both the end users and as well as me (in terms of support).

Nobody benefits from that confusion. The experience should be made easier and streamlined.

A lot of people without YAML knowledge flee to Node-RED. Yet, now all of a sudden, this happens, HACS, custom integration, add-on?!

We should aim for a single click and go experience.

zachowj commented 3 years ago

It is my understanding it would fail acceptance because of this as it makes direct calls to Node-RED from the HA entities as it using an existing websocket connection initiated from Node-RED.

frenck commented 3 years ago

Initiate a separate connection for that?

zachowj commented 3 years ago

something change?

frenck commented 3 years ago

No.

That is why I closed it.