zachsaw / MPDN_Extensions

Media Player .Net (MPDN) Open Source Extensions
Other
58 stars 18 forks source link

Add an on-screen display #236

Closed Garteal closed 7 years ago

Garteal commented 7 years ago

OSD becomes a bit unresponsive in visual feedback when the player is paused because it paints at a lower rate, but there's nothing that can be done about it at the moment.

Also it'd be nice if we could disable the internal OSD for MPDN as it stack ups right now.

Right now it:

I'd also like to make this responsive (e.g. bigger fonts on bigger screens) later.

Shiandow commented 7 years ago

Hi Garteal,

Just tried it out, it looks nice. I can see if there's an easy way to allow you to disable / override MPDN's OSD, which parts should be disabled?

By the way, I think its probably also a good idea to add a quick option to disable your OSD, just in case people don't want one.

Garteal commented 7 years ago

@Shiandow Glad you like it.

I've been meaning to push a small fixup to this, but been a bit busy, but no worries! I'll push that soon anyways.

I can see if there's an easy way to allow you to disable / override MPDN's OSD, which parts should be disabled?

When playing or changing the media, the player will display the title of whatever is being played by default. With the OSD enabled it's not needed anymore. untitled

Basically the media title, and whatever state the player is in at the moment, e.g. play, pause, etc. Perhaps add a flag that a PlayerExtension can modify? So that the internal OSD is enabled by default and when the OSD extension is enabled, the extension disables it.

By the way, I think its probably also a good idea to add a quick option to disable your OSD, just in case people don't want one.

You're absolutely right. I'll set it to be disabled by default.

*side note: I should probably add shadows to the text

Shiandow commented 7 years ago

I see, shouldn't be too difficult to add a simple flag to stop MPDN from displaying the title.

By the way, the close button also overlaps with the window controls if you're using the 'minimalist' mode of MPDN, do you want to be able to disable those as well? Alternatively you could just not show the close button in windowed mode.

Garteal commented 7 years ago

@Shiandow I completely forgot about that. I like both controls though. I guess it couldn't hurt to add the option to disable those as well?

Shiandow commented 7 years ago

It's probably good if those can be disabled as well. The more behaviour we can move from MPDN to player extensions the better. Also, if you could find some time to add minimize/maximize buttons, then that would solve issue #83.