search

zachtes13 / comp3004_aed-sim

1 stars 0 forks source link

#32 Implemented Battery Replacement feature #35

Closed AdamLuczaj closed 1 year ago

AdamLuczaj commented 1 year ago

Implemented a Battery Replacement feature for the UI.

AdamLuczaj commented 1 year ago

Need this to be merged before working on the patient wakeup code (ui code will conflict).

zachtes13 commented 1 year ago

@AdamLuczaj, this is good to merge after adding the repaint() calls.

AdamLuczaj commented 1 year ago

@zachtes13 I have no idea what you mean by repaint(), please tell me what this is.

VinceCardillo commented 1 year ago

I think the buttons look better like this, there was a lot of empty space before. image

We could also do something like this if we think we need to add several more buttons. image

zachtes13 commented 1 year ago

@zachtes13 I have no idea what you mean by repaint(), please tell me what this is.

Check out line 105 in MainWindow where we’ve used this before. Just ensures the UI updates dynamically while the application runs

AdamLuczaj commented 1 year ago

@zachtes13 @VinceCardillo please review again and you can merge it on your own. I had to change the ui height because I couldn't figure out how to change it with static numbers to make it as it was before but i made the ui smaller. this nitpicking about the specific height size isn't super important.