Now works in Safari and set utf-8 with BOM encoding

zachwick / TableCSVExport

jQuery plugin to convert HTML table to CSV

http://zachwick.com/?p=87

43 stars 30 forks source link

Now works in Safari and set utf-8 with BOM encoding #11

Closed Ivan-Feofanov closed 8 years ago

rubo77 commented 8 years ago

Can you Please refractor this without changing the indention?

Use git --amend

Ivan-Feofanov commented 8 years ago

Done.

rubo77 commented 8 years ago

better, but still not completely correct. see "files changed" in this PR: https://github.com/zachwick/TableCSVExport/pull/11/files

please use exactly 4 spaces as indention on each level.

It seems, like there was a bug where there were 8 spaces in one part, that can be corrected too.

And when you are finished, plese rebase this as only one commit.

Ivan-Feofanov commented 8 years ago

I think now it's allright with intendation. I use only 4 space to intend.

zachwick commented 8 years ago

Thanks a bunch for this @Ivan-Feofanov and @rubo77! I'm sorry that I am just now merging it in - it looks like I inadvertently turned off notifications for all repos, not just some.