search

zackbrown / famous-angular-ui-router

Simple demo of using ui-router with Famo.us/Angular
12 stars 7 forks source link

Leave animation not running - leaving element is removed instantly #5

Closed mrlund closed 9 years ago

mrlund commented 9 years ago

I've been trying to figure out why or when, but basically the leaving surface is immediately set to opacity 0. The $done callback seems to execute right away (before the animation completes), which could be consistant with the operation for a Transitionable to execute on the first get?

I've tried preventing the $done callback from ever being called in my .leave and .enter functions but it doesn't seem to make any difference.

I'm new at famo.us so I'm clutching at straws here, but I'm happy to provide further investigation if guided.

zackbrown commented 9 years ago

I was able to reproduce this on master (as of 4e34a22fdc1a8f8a1a64be7ef5f2c81c1e4c21c1) but not on 0.4.0—were you using master?

Looks like this was a bug introduced by 4e34a22fdc1a8f8a1a64be7ef5f2c81c1e4c21c1 (broken exit transitions, but enter transitions were working correctly) — thanks for catching this! 4e34a22fdc1a8f8a1a64be7ef5f2c81c1e4c21c1 is reverted by 4f17d71ee27587f03d1897fac8040ee2ce625f3e and exit transitions are working correctly for me after that update. Either master or 0.4.0 should work now.

Let me know if you were using 0.4.0, though, and we can track down what else may be going on.

mrlund commented 9 years ago

I was using master, and after updating today (as of fb3205df11b3095dbf1f569f098dd99062fd797b) the issue is gone and my route animations are working brilliantly! Thanks!