search

zackchase / mxnet-the-straight-dope

An interactive book on deep learning. Much easy, so MXNet. Wow. [Straight Dope is growing up] ---> Much of this content has been incorporated into the new Dive into Deep Learning Book available at https://d2l.ai/.
https://d2l.ai/
Apache License 2.0
2.56k stars 725 forks source link

data_ctx in MLP tutorial is defined but never used #440

Open ferakon opened 6 years ago

ferakon commented 6 years ago

I have been working through the gluon tutorials and found that in http://gluon.mxnet.io/chapter03_deep-neural-networks/mlp-gluon.html after the declaration of:

data_ctx = mx.cpu()

data_ctx is never actually used in the code. Unless I'm just being dense.

QiXuanWang commented 6 years ago

Actually I would suggest author to remove most of the data_ctx in examples except maybe for one specific topic. It's a simple and straight concept but usually won't help a lot in simple/small-data examples.