search

zackchase / mxnet-the-straight-dope

An interactive book on deep learning. Much easy, so MXNet. Wow. [Straight Dope is growing up] ---> Much of this content has been incorporated into the new Dive into Deep Learning Book available at https://d2l.ai/.
https://d2l.ai/
Apache License 2.0
2.56k stars 724 forks source link

Fix typo in linear-regression-scratch.ipynb #534

Closed imgarylai closed 5 years ago

imgarylai commented 5 years ago

fix variable naming. counter should be renamed as i.

zackchase commented 5 years ago

That doesn't actually make sense since i is overwritten immediately by enumerate. However you may be right that counter might not longer be used in the current version. Will kill the PR but try to clean this section to remove the counter = 0 line.

imgarylai commented 5 years ago

Thanks for your time and reviewing this less important issue.

You're right. The i is overwritten by the enumerate and that's what I thought. I created this pull request because I didn't know why I got the error message showing the i was not defined. And, I thought the variable counter probably had the same meaning of the i. I should have reviewed it again.

Unfortunately, the strange thing is I can not duplicate this situation again. The code perfect on my machine now. That's the more important thing!

Again, I really appreciate your awesome works!

Best,