search

zackchase / mxnet-the-straight-dope

An interactive book on deep learning. Much easy, so MXNet. Wow. [Straight Dope is growing up] ---> Much of this content has been incorporated into the new Dive into Deep Learning Book available at https://d2l.ai/.
https://d2l.ai/
Apache License 2.0
2.57k stars 725 forks source link

Images messed up in live version (gluon.mxnet.io), but look good in Github version #552

Open vitali-fedulov opened 6 years ago

vitali-fedulov commented 6 years ago

Images are in wrong order/position on page: https://gluon.mxnet.io/chapter01_crashcourse/introduction.html

But all good on corresponding Github: https://github.com/zackchase/mxnet-the-straight-dope/blob/master/chapter01_crashcourse/introduction.ipynb

vishaalkapoor commented 6 years ago

@vitali-fedulov can you include a screenshot with specification to the specific images out of place? It looks fine on my browser.

What browser are you using? Desktop/mobile? Can you try a different one to be sure?

vitali-fedulov commented 6 years ago

I have tried it in most recent Chrome, Firefox in Ubuntu, and Firefox in Android. All show the same incorrect images:

Live:

live

Live HTML:

screenshot from 2018-11-30 17-22-52

GitHub version (as it should be):

git

vitali-fedulov commented 6 years ago

Google cache also looks incorrect (link relevant at this moment): http://webcache.googleusercontent.com/search?q=cache%3Ahttps%3A%2F%2Fgluon.mxnet.io%2Fchapter01_crashcourse%2Fintroduction.html&oq=cache%3Ahttps%3A%2F%2Fgluon.mxnet.io%2Fchapter01_crashcourse%2Fintroduction.html&aqs=chrome..69i57j69i58.2224j0j4&sourceid=chrome&ie=UTF-8

screenshot from 2018-11-30 17-54-48

vishaalkapoor commented 6 years ago

nice catch.

It looks like it's this issue with Sphinx: https://github.com/spatialaudio/nbsphinx/issues/162

it only happens when the "alt" tag for an image is an empty string. i see a few empty alt tags, so it could be useful to try to fill those in with some relevant text. if you want to give it a go and try adding alt image text feel free to submit a PR and i can take a look.

if not, I'll leave this issue open and someone, myself included might be able to get to it

vishaalkapoor commented 6 years ago

@vitali-fedulov Looks like the merge fixed the issue, Thank you! I'll let you double check and close off this issue.

vitali-fedulov commented 6 years ago

It looks much better, except it now has a block of same dog image instead of mix of dogs and cats.

It seems the issue is somewhat more complicated. In the end adding the alt tags is a temporary solution not fixing the root problem with the document conversion tool. The tool probably has object indexing implementation wrong.

I will not have time to look more until middle next week. Maybe you have time to?

On Sat, 1 Dec 2018, 22:09 Vishaal Kapoor, notifications@github.com wrote:

@vitali-fedulov https://github.com/vitali-fedulov Looks like the merge fixed the issue, Thank you! I'll let you double check and close off this issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zackchase/mxnet-the-straight-dope/issues/552#issuecomment-443458702, or mute the thread https://github.com/notifications/unsubscribe-auth/AqngCNPnGa7Q42Deb618NRksFhIEJG1Dks5u0vABgaJpZM4Y662x .

vishaalkapoor commented 6 years ago

I think this will need to be fixed within Sphinx (possibly version upgrade). Leaving this issue open.