zackdreaver / ROenglishRE

An unofficial english translation project for Korea Ragnarok Online (kRO).
144 stars 173 forks source link

Fix langtype 1 on sclientinfo.xml on newer clients #25

Closed Mikegyver closed 6 years ago

Mikegyver commented 7 years ago

Fix langtype 1 on sclientinfo.xml on 2017-06-28bRagexeRE & newer RE clients. Thanks to @Rytech2 for the lua file.

Daegaladh commented 7 years ago

I thought you only need that one when you have <servicetype>america</servicetype>, not with langtype 1 D:

Mikegyver commented 7 years ago

well.. lots of changes happen i guess.. as long as this fix the error in langtype 1 in the sclientinfo.xml for 2017-06-28bRagexeRE & newer RE clients... it is kinda relieve this error has gone. xD

--------------------------- GetTableIntValueForC --------------------------- attempt to call a nil value ` --------------------------- OK ---------------------------`

zackdreaver commented 7 years ago

I don't have this client, I can't test if this PR will do any fix.

Mikegyver commented 7 years ago

@zackdreaver u can get them from here.

http://herc.ws/board/topic/15348-kro-unpacked-clients-releases/

zackdreaver commented 7 years ago

I'll announce my standpoint regarding newer clients (2017-06-28 and up) in forum later. There are many issues with new clients, and this is only a small one.

zackdreaver commented 6 years ago

I've updated README.md regarding newer clients, thank you for your understanding.