zackexplosion / swfobject

Automatically exported from code.google.com/p/swfobject
1 stars 0 forks source link

swfobject does not work with UglifyJS #616

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. try to compress swfobject with uglifyJS
2. the code for ie detection ("\v1") will be transformed in "!1"
3. try to convince the uglifyjs guys that the problem is theirs 

What is the expected output? What do you see instead?
version 2.1 of swfobject used conditional comments and that won't work too 
(uglifyjs removes conditional comments)

What version of the product are you using? On what operating system?
I'm using swfobject 2.2. Maybe you can just use a match on the user agent 
string for IE and live with that?

Please provide any additional information below.

https://github.com/mishoo/UglifyJS/issues/307

Original issue reported on code.google.com by claudio....@gmail.com on 30 Jan 2012 at 9:11

GoogleCodeExporter commented 9 years ago
This is not a defect or bug in SWFObject.

Also, the SWFObject 2.3 beta no longer uses the "\v1" code. 
https://github.com/swfobject/swfobject

Original comment by platelu...@gmail.com on 30 Jan 2012 at 9:23

GoogleCodeExporter commented 9 years ago
In addition, the swfobject library already has  a minified version, so I am 
unsure why you would need to recompress it...

Original comment by aran.rhee@gmail.com on 30 Jan 2012 at 10:00

GoogleCodeExporter commented 9 years ago
We are now using the 2.3 beta, thank you (I didn't see you moved to github). 
The "asset compression" task is part of our build process, and we have no way 
to fine tune it. That's why swfobject is being compressed again.

Original comment by claudio....@gmail.com on 30 Jan 2012 at 10:29