Variable/class names are not consistent with PEP8 standard: see list of suggested names. Also, names like disc, disc2, disc3 should have more descriptive function names.
Suggested solution:
Rename variables and class names to be consistent with PEP8 standard. Ensure that the script updates throughout its references to variables and class names.
Suggested names:
Notes:
[dict needed?] - we can add this information in the contributor documentation of the variable
Variable/class names are not consistent with PEP8 standard: see list of suggested names. Also, names like
disc,disc2,disc3should have more descriptive function names.Suggested solution:
Rename variables and class names to be consistent with PEP8 standard. Ensure that the script updates throughout its references to variables and class names.
Suggested names:
Notes: [dict needed?] - we can add this information in the contributor documentation of the variable
BayesianNetwork.py BNdata -> bn_data netStructure -> net_structure learnedBaynet -> learned_baynet BinRanges -> bin_ranges binnedData -> binned_data Vdata -> v_data priorPDs -> prior_posterior_dists varName -> var_name inferPD -> infer_posterior_dist inferPD_2 -> infer_posterior_dist_2 inferPD_3 -> infer_posterior_dist_pd3 inferPD_4 -> infer_posterior_dist_pd4 inferPD_JT_hard -> infer_posterior_dist_jt_hard inferPD_JT_soft -> infer_posterior_dist_jt_soft inferPosteriorDistribution -> infer_posterior_dist queriedMarginalPosteriors -> queried_marginal_posteriors postInferencePDs -> post_infererence_posterior_dists marginalPosterior -> marginal_posteriors assembledP -> assembled_pXXXXXXX? allStatesQueriedMarginalPosteriors -> all_states [unless used publicly] assembledPosteriors -> assembled_posteriors evidencePD -> evidence_posterior_dist assembledPosterior -> assembled_posterior queryVarName -> var_name sequenceDict -> sequence_dict inferWithJunctionTree -> infer_with_junction_tree evidenceVarName -> var_name crossValidate -> cross_validate targetList -> target_list kfoldToDF -> k_fold_to_df trainingData -> train_data binnedTrainingDict -> binned_train_dict binnedTestingDict -> binned_test_dict binnedTrainingData -> binned_train_data binnedTestingData -> binned_test_data binCountsTr -> bin_counts_train binCountsTest -> bin_counts_test marginalTargetPosteriorsDict -> marginal_target_posteriors [dict needed here?] generateErrors -> generate_errors numFolds -> num_folds validateNew -> validate_new hardEvidence -> hard_evidence formattedEvidence -> formatted_evidence pybbnToLibpgm_posteriors -> pybbn_transform_posteriors pybbnPosteriors -> pybbn_posteriors evidenceList -> evidence_list posteriorsDict -> posteriors [dict needed?] softEvidence -> soft_evidence convertEvidence -> convert_evidence humanEvidence -> human_evidence binRange -> bin_range
BN_Metamodel_easy.py binTypeDict -> bin_type [dict needed?] numBinsDict -> num_bins [dict needed?] kwarg: "numBinsDict" -> "num_bins" [dict needed?] learnedBaynet -> learned_baynet changeNumBinsDict -> change_num_bins [dict needed?] inferPD_JT_hard -> infer_posterior_dist_jt_hard inferPD_JT_soft -> infer_posterior_dist_jt_soft inferPD_VE_hard -> infer_posterior_dist_ve_hard
BNdata.py BNdata -> bn_data numBinsDict -> num_bins [dict needed?] binTypeDict -> bin_type [dict needed?] binnedDict -> binned [dict needed?] binnedData -> binned_data bincountsDict -> bin_counts [dict needed?]
Helper_functions.py loadDataFromCSV -> load_data [from CSV seems like something that could be passed as only possible kwarg for now] kfoldToList -> k_fold_to_list inferPosteriorDistribution -> infer_posterior_dist numBins -> num_bins buildBN -> build_bn trainingData -> train_data binstyleDict -> bin_style [dict needed?] numbinsDict -> num_bins [dict needed?] expectedValue -> expected_value binRanges -> bin_ranges expectedV -> expected_value meanBinvalue -> mean_bin_value binRangesDict -> bin_ranges [dict needed?] binnedDf -> df_binned binCountsDict -> bin_counts [dict needed?] varName -> var_name discreteRanges -> discrete_ranges binRange -> bin_range binnedData -> data_binned getBinRanges -> get_bin_ranges binTypeDict -> bin_type [dict needed?] trainingDfDiscterizedRanges -> train_df_discrete_ranges trainingDfDiscterizedRangesDict -> train_df_discrete_ranges_dict generateErrors -> generate_errors predictedTargetPosteriors -> predicted_target_posteriors testingData -> test_data binnedTestingData -> test_data_binned posteriorPDmeans -> posterior_dist_means [verify] BNskelFromCSV -> bn_skel_from [move CSV to kwarg?] BNstructure -> bn_structure inputVerts -> input_vertices allVertices -> all_vertices